# 488: Two Slices of Complimentary Bread

- Show: [Embedded.fm](https://hardwarepodcasts.com/podcast/embedded-fm)
- Published: 2024-10-31
- Length: 1h 10m
- Episode: 488
- Page: https://hardwarepodcasts.com/podcast/embedded-fm/2024-10-31-488-two-slices-of-complimentary-bread
- Listen: https://embedded.fm/episodes/488

## Summary

Adrienne Braganza Tacke, author of 'Looks Good To Me: Constructive Code Reviews,' explains why code reviews are often dreaded and how to make them effective. She advocates for creating a Team Working Agreement to make implicit expectations explicit, using comment signals to prioritize feedback, and employing the 'triple R pattern' (request, rationale, result) to write objective comments. The discussion covers the impact of tools like GitHub PRs versus email, the time required for thorough reviews, and the importance of catching design issues before coding begins.

## Chapters

- [0:06](https://hardwarepodcasts.com/podcast/embedded-fm/2024-10-31-488-two-slices-of-complimentary-bread#t=6) Introduction: Adrienne Braganza Tacke and her book
- [5:02](https://hardwarepodcasts.com/podcast/embedded-fm/2024-10-31-488-two-slices-of-complimentary-bread#t=302) Why code reviews are hated and the Team Working Agreement
- [14:32](https://hardwarepodcasts.com/podcast/embedded-fm/2024-10-31-488-two-slices-of-complimentary-bread#t=872) Comment signals and categorizing feedback
- [19:03](https://hardwarepodcasts.com/podcast/embedded-fm/2024-10-31-488-two-slices-of-complimentary-bread#t=1143) Writing objective comments with the triple R pattern
- [24:09](https://hardwarepodcasts.com/podcast/embedded-fm/2024-10-31-488-two-slices-of-complimentary-bread#t=1449) Tools influence: Email vs. GitHub PRs vs. Fagan inspections
- [30:28](https://hardwarepodcasts.com/podcast/embedded-fm/2024-10-31-488-two-slices-of-complimentary-bread#t=1828) Time required for code reviews and managing metrics
- [39:12](https://hardwarepodcasts.com/podcast/embedded-fm/2024-10-31-488-two-slices-of-complimentary-bread#t=2352) Design reviews vs. code reviews and handling edge cases
- [48:17](https://hardwarepodcasts.com/podcast/embedded-fm/2024-10-31-488-two-slices-of-complimentary-bread#t=2897) The editing process as a proxy for code review
- [56:27](https://hardwarepodcasts.com/podcast/embedded-fm/2024-10-31-488-two-slices-of-complimentary-bread#t=3387) Reviewer responsibilities: Compiling and testing

## Topics

- [Embedded firmware](https://hardwarepodcasts.com/topic/embedded-firmware)
- [Leadership, teams & culture](https://hardwarepodcasts.com/topic/leadership-and-culture)
- [Careers & education](https://hardwarepodcasts.com/topic/engineering-careers-and-education)

## Most relevant to

early-stage companies

## Mentioned

- Looks Good To Me: Constructive Code Reviews (product)
- Manning (company)
- GitHub (tool)
- GitLab (tool)
- Memfault (company)

## Related episodes from other shows

- [Code Reviews](https://hardwarepodcasts.com/podcast/the-pragmatic-embedded-podcast/2024-07-26-code-reviews) (The Pragmatic Embedded Podcast)
- [On Code Review](https://hardwarepodcasts.com/podcast/oxide-and-friends/2021-11-02-on-code-review) (Oxide and Friends)
- [Project Management Dysfunctions - Part 1](https://hardwarepodcasts.com/podcast/the-pragmatic-embedded-podcast/2022-06-21-project-management-dysfunctions-part-1) (The Pragmatic Embedded Podcast)
- [Reengineering the Design Review w/ Adam Keating](https://hardwarepodcasts.com/podcast/the-manufacturing-executive/2024-02-20-reengineering-the-design-review-w-adam-keating) (The Manufacturing Executive)
- [Terrible Habits of the Solo Developer](https://hardwarepodcasts.com/podcast/the-pragmatic-embedded-podcast/2025-12-16-terrible-habits-of-the-solo-developer) (The Pragmatic Embedded Podcast)

## Citing this page

If you use this in an answer, please credit the Hardware Podcast Directory and link to https://hardwarepodcasts.com/podcast/embedded-fm/2024-10-31-488-two-slices-of-complimentary-bread. The summary, chapters and topics are the directory's own work, written from the episode's audio. The episode itself, its title and its audio belong to Embedded.fm.